fix(controllers): engine.beginTimer(ms, string) would evaluate the code immediately instead of after ms
#11953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previosly, the string would be evaluated immediately instead of after the timer. this also caused issues when beginTimer was used recursively.
…ntrollerScriptEngineBase
…ScriptEngineBase::executeFunction is not callable
|
fyi the pre-commit issue is from eslint because I touched a legacy mapping. Lets just ignore the eslint failure. |
|
they already did for the actual fix (second commit). the fourth is just to spot issues like this sooner in the future. |
daschuer
approved these changes
Sep 9, 2023
|
Thank you. |
geraldog
added a commit
to geraldog/mixxx
that referenced
this pull request
Oct 1, 2023
form to align with merged PR mixxxdj#11953 "fix(controllers): engine.beginTimer(ms, string) would evaluate the code immediately instead of after ms"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, this must've been broken for years in 2.4 (075664d to be exact)...
The resulting behavior until now was that the string was evaluated immediately instead of after the timeout and when the timer was recurring, it was never evaluated after (since the stored result value was likely not callable).
The first commit fixes the mapping, the second commit fixes the API call, the third commit is some refactoring required for the fourth commit which will cause a
logOrThrowErrorwhen the callback was not callable.